lianetm commented on code in PR #14690:
URL: https://github.com/apache/kafka/pull/14690#discussion_r1395877609
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##########
@@ -168,10 +319,37 @@ public void
updateState(ConsumerGroupHeartbeatResponseData response) {
this.memberId = response.memberId();
this.memberEpoch = response.memberEpoch();
ConsumerGroupHeartbeatResponseData.Assignment assignment =
response.assignment();
+
if (assignment != null) {
- setTargetAssignment(assignment);
+ transitionTo(MemberState.RECONCILING);
+ replaceUnresolvedAssignmentWithNewAssignment(assignment);
+ resolveMetadataForUnresolvedAssignment();
+ // TODO: improve reconciliation triggering. Initial approach of
triggering on every
+ // HB response and metadata update.
Review Comment:
Agree, done. All TODOs in this class have jiras already.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
