divijvaidya commented on code in PR #14794:
URL: https://github.com/apache/kafka/pull/14794#discussion_r1398097515
##########
core/src/test/java/kafka/server/AssignmentsManagerTest.java:
##########
@@ -72,6 +75,29 @@ void tearDown() throws InterruptedException {
manager.close();
}
+ AssignReplicasToDirsRequestData normalize(AssignReplicasToDirsRequestData
request) {
Review Comment:
I was wondering if we can find a way to overriding equals() for
AssignReplicasToDirsRequestData with this deep check. I understand that it is
auto generated but wanted to check the ideas we have tried in that regard ?
I am concerned about this because if we add a new field to this data
structure in future, it's quite likely to forget to add it here in the setters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
