ijuma commented on code in PR #14794:
URL: https://github.com/apache/kafka/pull/14794#discussion_r1398417831
##########
core/src/test/java/kafka/server/AssignmentsManagerTest.java:
##########
@@ -72,6 +75,29 @@ void tearDown() throws InterruptedException {
manager.close();
}
+ AssignReplicasToDirsRequestData normalize(AssignReplicasToDirsRequestData
request) {
Review Comment:
This approach results in more maintenance, any change to this schema will
require changing this method. I don't agree it's better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
