dajac commented on code in PR #14758:
URL: https://github.com/apache/kafka/pull/14758#discussion_r1404226250
##########
core/src/test/scala/integration/kafka/api/BaseConsumerTest.scala:
##########
@@ -111,6 +115,40 @@ abstract class BaseConsumerTest extends
AbstractConsumerTest {
}
object BaseConsumerTest {
+ // We want to test the following combinations:
+ // * ZooKeeper and the generic group protocol
+ // * KRaft and the generic group protocol
+ // * KRaft with the new group coordinator enabled and the consumer group
protocol
+ def getTestQuorumAndGroupProtocolParametersAll() :
java.util.stream.Stream[Arguments] = {
+ java.util.stream.Stream.of(
+ Arguments.of("zk", "generic"),
+ Arguments.of("kraft", "generic"),
+ Arguments.of("kraft+kip848", "consumer"))
+ }
+
+ // We want to test the following combinations:
+ // * ZooKeeper and the generic group protocol
+ def getTestQuorumAndGroupProtocolParametersZkOnly() :
java.util.stream.Stream[Arguments] = {
+ java.util.stream.Stream.of(
+ Arguments.of("zk", "generic"))
+ }
+
+ // For tests that only work with the generic group protocol, we want to test
the following combinations:
+ // * ZooKeeper and the generic group protocol
+ // * KRaft and the generic group protocol
+ def getTestQuorumAndGroupProtocolParametersGenericGroupProtocolOnly() :
java.util.stream.Stream[Arguments] = {
+ java.util.stream.Stream.of(
+ Arguments.of("zk", "generic"),
+ Arguments.of("kraft", "generic"))
Review Comment:
We likely need it here too.
##########
core/src/test/scala/integration/kafka/api/BaseConsumerTest.scala:
##########
@@ -111,6 +115,40 @@ abstract class BaseConsumerTest extends
AbstractConsumerTest {
}
object BaseConsumerTest {
+ // We want to test the following combinations:
+ // * ZooKeeper and the generic group protocol
+ // * KRaft and the generic group protocol
+ // * KRaft with the new group coordinator enabled and the consumer group
protocol
+ def getTestQuorumAndGroupProtocolParametersAll() :
java.util.stream.Stream[Arguments] = {
+ java.util.stream.Stream.of(
+ Arguments.of("zk", "generic"),
+ Arguments.of("kraft", "generic"),
+ Arguments.of("kraft+kip848", "consumer"))
Review Comment:
We also need to test the `generic` with `kraft+kip848`. This is what all the
tests with `kraft+kip848` prior to your change did.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
