lucasbru commented on code in PR #14758:
URL: https://github.com/apache/kafka/pull/14758#discussion_r1405954797
##########
core/src/test/scala/integration/kafka/api/BaseConsumerTest.scala:
##########
@@ -36,14 +36,15 @@ import scala.collection.Seq
*/
abstract class BaseConsumerTest extends AbstractConsumerTest {
- @ParameterizedTest(name = TestInfoUtils.TestWithParameterizedQuorumName)
- @ValueSource(strings = Array("zk", "kraft", "kraft+kip848"))
- def testSimpleConsumption(quorum: String): Unit = {
+ @ParameterizedTest(name =
TestInfoUtils.TestWithParameterizedQuorumAndGroupProtocolNames)
+ @MethodSource(Array("getTestQuorumAndGroupProtocolParametersAll"))
+ def testSimpleConsumption(quorum: String, groupProtocol: String): Unit = {
val numRecords = 10000
val producer = createProducer()
val startingTimestamp = System.currentTimeMillis()
sendRecords(producer, numRecords, tp, startingTimestamp =
startingTimestamp)
+ this.consumerConfig.setProperty(ConsumerConfig.GROUP_PROTOCOL_CONFIG,
groupProtocol)
Review Comment:
Can we remove this line now?
##########
core/src/test/scala/integration/kafka/api/BaseConsumerTest.scala:
##########
@@ -69,6 +70,7 @@ abstract class BaseConsumerTest extends AbstractConsumerTest {
sendRecords(producer, numRecords, tp, startingTimestamp =
startingTimestamp)
val consumerProps = new Properties()
+ this.consumerConfig.setProperty(ConsumerConfig.GROUP_PROTOCOL_CONFIG,
groupProtocol)
Review Comment:
Can we remove this line now?
##########
core/src/test/scala/integration/kafka/api/BaseConsumerTest.scala:
##########
@@ -78,10 +80,12 @@ abstract class BaseConsumerTest extends
AbstractConsumerTest {
assertNotEquals(0, BaseConsumerTest.updateConsumerCount.get())
}
- @ParameterizedTest(name = TestInfoUtils.TestWithParameterizedQuorumName)
- @ValueSource(strings = Array("zk", "kraft", "kraft+kip848"))
- def testCoordinatorFailover(quorum: String): Unit = {
+ // ConsumerRebalanceListener temporarily not supported for consumer group
protocol
+ @ParameterizedTest(name =
TestInfoUtils.TestWithParameterizedQuorumAndGroupProtocolNames)
+
@MethodSource(Array("getTestQuorumAndGroupProtocolParametersGenericGroupProtocolOnly"))
+ def testCoordinatorFailover(quorum: String, groupProtocol: String): Unit = {
val listener = new TestConsumerReassignmentListener()
+ this.consumerConfig.setProperty(ConsumerConfig.GROUP_PROTOCOL_CONFIG,
groupProtocol)
Review Comment:
can we remove this line now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
