apoorvmittal10 commented on code in PR #14811: URL: https://github.com/apache/kafka/pull/14811#discussion_r1407386356
########## clients/src/main/java/org/apache/kafka/common/requests/ListClientMetricsResourcesResponse.java: ########## @@ -0,0 +1,80 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.common.requests; + +import org.apache.kafka.clients.admin.ClientMetricsResourceListing; +import org.apache.kafka.common.message.ListClientMetricsResourcesResponseData.ClientMetricsResource; +import org.apache.kafka.common.message.ListClientMetricsResourcesResponseData; +import org.apache.kafka.common.protocol.ApiKeys; +import org.apache.kafka.common.protocol.ByteBufferAccessor; +import org.apache.kafka.common.protocol.Errors; + +import java.nio.ByteBuffer; +import java.util.ArrayList; +import java.util.Collection; +import java.util.Map; + +public class ListClientMetricsResourcesResponse extends AbstractResponse { + private final ListClientMetricsResourcesResponseData data; + + public ListClientMetricsResourcesResponse(ListClientMetricsResourcesResponseData data) { + super(ApiKeys.LIST_CLIENT_METRICS_RESOURCES); + this.data = data; + } + + public ListClientMetricsResourcesResponseData data() { + return data; + } + + public ApiError error() { + return new ApiError(Errors.forCode(data.errorCode())); + } + + @Override + public Map<Errors, Integer> errorCounts() { + return errorCounts(Errors.forCode(data.errorCode())); + } + + public static ListClientMetricsResourcesResponse parse(ByteBuffer buffer, short version) { + return new ListClientMetricsResourcesResponse(new ListClientMetricsResourcesResponseData( + new ByteBufferAccessor(buffer), version)); + } + + @Override + public String toString() { + return data.toString(); + } + + @Override + public int throttleTimeMs() { + return data.throttleTimeMs(); + } + + @Override + public void maybeSetThrottleTimeMs(int throttleTimeMs) { + data.setThrottleTimeMs(throttleTimeMs); + } + + public Collection<ClientMetricsResourceListing> clientMetricsResources() { + ArrayList<ClientMetricsResourceListing> resources = new ArrayList<>(data.clientMetricsResources().size()); Review Comment: nit ```suggestion List<ClientMetricsResourceListing> resources = new ArrayList<>(data.clientMetricsResources().size()); ``` ########## clients/src/main/java/org/apache/kafka/clients/admin/ClientMetricsResourceListing.java: ########## @@ -0,0 +1,54 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.clients.admin; + +import java.util.Objects; Review Comment: nit: I have generally followed the convention where `java.*` packages are after `org.*` and any `static import` are at last. I have generally seen that's how code is structured but not sure if this is always followed. ########## clients/src/main/java/org/apache/kafka/common/requests/ListClientMetricsResourcesResponse.java: ########## @@ -0,0 +1,80 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.common.requests; + +import org.apache.kafka.clients.admin.ClientMetricsResourceListing; +import org.apache.kafka.common.message.ListClientMetricsResourcesResponseData.ClientMetricsResource; +import org.apache.kafka.common.message.ListClientMetricsResourcesResponseData; +import org.apache.kafka.common.protocol.ApiKeys; +import org.apache.kafka.common.protocol.ByteBufferAccessor; +import org.apache.kafka.common.protocol.Errors; + +import java.nio.ByteBuffer; +import java.util.ArrayList; +import java.util.Collection; +import java.util.Map; + +public class ListClientMetricsResourcesResponse extends AbstractResponse { + private final ListClientMetricsResourcesResponseData data; + + public ListClientMetricsResourcesResponse(ListClientMetricsResourcesResponseData data) { + super(ApiKeys.LIST_CLIENT_METRICS_RESOURCES); + this.data = data; + } + + public ListClientMetricsResourcesResponseData data() { + return data; + } + + public ApiError error() { + return new ApiError(Errors.forCode(data.errorCode())); + } + + @Override + public Map<Errors, Integer> errorCounts() { + return errorCounts(Errors.forCode(data.errorCode())); + } + + public static ListClientMetricsResourcesResponse parse(ByteBuffer buffer, short version) { + return new ListClientMetricsResourcesResponse(new ListClientMetricsResourcesResponseData( + new ByteBufferAccessor(buffer), version)); + } + + @Override + public String toString() { + return data.toString(); + } + + @Override + public int throttleTimeMs() { + return data.throttleTimeMs(); + } + + @Override + public void maybeSetThrottleTimeMs(int throttleTimeMs) { + data.setThrottleTimeMs(throttleTimeMs); + } + + public Collection<ClientMetricsResourceListing> clientMetricsResources() { + ArrayList<ClientMetricsResourceListing> resources = new ArrayList<>(data.clientMetricsResources().size()); + for (ClientMetricsResource entry : data.clientMetricsResources()) { Review Comment: nit: maybe use `stream()` and `collect`, upto you. ########## core/src/main/scala/kafka/network/RequestConvertToJson.scala: ########## @@ -101,6 +101,7 @@ object RequestConvertToJson { case req: ConsumerGroupDescribeRequest => ConsumerGroupDescribeRequestDataJsonConverter.write(req.data, request.version) case req: ControllerRegistrationRequest => ControllerRegistrationRequestDataJsonConverter.write(req.data, request.version) case req: AssignReplicasToDirsRequest => AssignReplicasToDirsRequestDataJsonConverter.write(req.data, request.version) + case req: ListClientMetricsResourcesRequest => ListClientMetricsResourcesRequestDataJsonConverter.write(req.data, request.version) Review Comment: Seems the sequence of definitions earlier was alphabetical and got messed recently. Not sure if we should place this in the end or try to maintain alphabetical order, though good to have some order. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
