AndrewJSchofield commented on code in PR #14811:
URL: https://github.com/apache/kafka/pull/14811#discussion_r1407458791
##########
core/src/main/scala/kafka/network/RequestConvertToJson.scala:
##########
@@ -101,6 +101,7 @@ object RequestConvertToJson {
case req: ConsumerGroupDescribeRequest =>
ConsumerGroupDescribeRequestDataJsonConverter.write(req.data, request.version)
case req: ControllerRegistrationRequest =>
ControllerRegistrationRequestDataJsonConverter.write(req.data, request.version)
case req: AssignReplicasToDirsRequest =>
AssignReplicasToDirsRequestDataJsonConverter.write(req.data, request.version)
+ case req: ListClientMetricsResourcesRequest =>
ListClientMetricsResourcesRequestDataJsonConverter.write(req.data,
request.version)
Review Comment:
Yes, it's mostly ordered with the latest added to the end. I've ordered the
lists. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
