soarez commented on code in PR #14836: URL: https://github.com/apache/kafka/pull/14836#discussion_r1408408855
########## core/src/test/scala/unit/kafka/server/BrokerLifecycleManagerTest.scala: ########## @@ -201,7 +201,7 @@ class BrokerLifecycleManagerTest { while (!future.isDone || context.mockClient.hasInFlightRequests) { context.poll() manager.eventQueue.wakeup() - context.time.sleep(100) + context.time.sleep(5) Review Comment: Thanks for raising this @junrao `manager.propagateDirectoryFailure` is called from `replicaManager.handleLogDirFailure` which handles directory failure only once for each directory. In most cases, the number of configured directories per broker should be under 10. Even if we consider 30, there can be 29 extra `HeartBeatRequest`s (the last one shuts down the broker). Maybe I'm missing something, but I don't expect these to overwhelm the controller. That said, if you still think this may be an issue, we can avoid triggering a separate `HearBeatRequest` and just wait for the next one. Otherwise, I think it makes sense not to delay updating leadership and ISR as necessary after any directory failure. What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org