junrao commented on code in PR #14836:
URL: https://github.com/apache/kafka/pull/14836#discussion_r1408460800
##########
core/src/test/scala/unit/kafka/server/BrokerLifecycleManagerTest.scala:
##########
@@ -201,7 +201,7 @@ class BrokerLifecycleManagerTest {
while (!future.isDone || context.mockClient.hasInFlightRequests) {
context.poll()
manager.eventQueue.wakeup()
- context.time.sleep(100)
+ context.time.sleep(5)
Review Comment:
@soarez : Just to be clear. In your example, there will be 29 extra
`HeartBeatRequest`s continuously every heartbeat interval, right? It may not
overwhelm the broker. But it's unnecessary work and makes debugging much harder.
We don't necessarily need to delay the propagation of failed disks. For
example, when adding HeartBeatRequest to the queue, if the schedule is earlier
than a pending `HeartBeatRequest` in the queue, we could cancel the pending
request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
