mjsax commented on code in PR #14843: URL: https://github.com/apache/kafka/pull/14843#discussion_r1410962382
########## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ########## @@ -957,7 +972,11 @@ public void commitSync(Map<TopicPartition, OffsetAndMetadata> offsets, Duration @Override public Uuid clientInstanceId(Duration timeout) { - throw new KafkaException("method not implemented"); + if (!clientTelemetryReporter.isPresent()) { + throw new IllegalStateException("Telemetry is not enabled. Set config `enable.metrics.push` to `true`."); Review Comment: Should we use `ConsumerConfig.ENABLE_METRICS_PUSH_CONFIG` instead of hardcoding `enable.metrics.push` ? Same on other places. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org