philipnee commented on code in PR #14843:
URL: https://github.com/apache/kafka/pull/14843#discussion_r1412837060
##########
clients/src/main/java/org/apache/kafka/clients/NetworkClient.java:
##########
@@ -1222,6 +1249,95 @@ private InProgressData(int requestVersion, boolean
isPartialUpdate) {
}
+ class TelemetrySender {
+
+ private final ClientTelemetrySender clientTelemetrySender;
+ private Node stickyNode;
+
+ public TelemetrySender(ClientTelemetrySender clientTelemetrySender) {
+ this.clientTelemetrySender = clientTelemetrySender;
+ }
+
+ public long maybeUpdate(long now) {
+ long timeToNextUpdate =
clientTelemetrySender.timeToNextUpdate(defaultRequestTimeoutMs);
Review Comment:
to be more consistent, can we do `long nowMs` and `long timeToNextUpdateMs =
...`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
