mjsax commented on code in PR #14864:
URL: https://github.com/apache/kafka/pull/14864#discussion_r1413296164
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/ActiveTaskCreator.java:
##########
@@ -136,8 +135,8 @@ StreamsProducer streamsProducerForTask(final TaskId taskId)
{
}
StreamsProducer threadProducer() {
- if (processingMode != EXACTLY_ONCE_V2) {
- throw new IllegalStateException("Expected EXACTLY_ONCE_V2 to be
enabled, but the processing mode was " + processingMode);
+ if (processingMode == EXACTLY_ONCE_ALPHA) {
Review Comment:
Yes. When this code was added, there was no reason to call this method for
ALOS and to get the producer out -- only for EOSv2 it was required for error
handling. Thus, the check was very restrictive.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
