lucasbru commented on code in PR #14922: URL: https://github.com/apache/kafka/pull/14922#discussion_r1417077988
########## streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java: ########## @@ -713,6 +727,48 @@ boolean runLoop() { return true; } + // visible for testing + void maybeGetClientInstanceIds() { Review Comment: I think there is a risk here that if the client calls `clientInstanceIds` faster than we are going around the poll loop, we will have an every-growing number of futures to complete, and in each iteration we can only complete one. We may also run out of time this way. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org