soarez commented on code in PR #14881:
URL: https://github.com/apache/kafka/pull/14881#discussion_r1416239117
##########
core/src/test/scala/unit/kafka/log/LogManagerTest.scala:
##########
@@ -93,6 +93,54 @@ class LogManagerTest {
log.appendAsLeader(TestUtils.singletonRecords("test".getBytes()),
leaderEpoch = 0)
}
+ /**
+ * Test that getOrCreateLog on a non-existent log creates a new log in given
logDirectory using directory id and that we can append to the new log.
+ */
+ @Test
+ def testCreateLogOnTargetedLogDirectory(): Unit = {
+ val targetedLogDirectoryId = DirectoryId.random()
+
+ val dirs: Seq[File] = Seq.fill(5)(TestUtils.tempDir())
+ writeMetaProperties(dirs(0))
+ writeMetaProperties(dirs(1), Optional.of(targetedLogDirectoryId))
+ writeMetaProperties(dirs(3), Optional.of(DirectoryId.random()))
+ writeMetaProperties(dirs(4))
+
+ logManager = createLogManager(dirs)
+
+ val log = logManager.getOrCreateLog(new TopicPartition(name, 0), topicId =
None, targetLogDirectoryId = Some(targetedLogDirectoryId))
+ assertEquals(5, logManager.liveLogDirs.size)
+
+ val logFile = new File(dirs(1), name + "-0")
+ assertTrue(logFile.exists)
+ assertEquals(dirs(1).getAbsolutePath, logFile.getParent)
+ log.appendAsLeader(TestUtils.singletonRecords("test".getBytes()),
leaderEpoch = 0)
+ }
+
+ /**
+ * Test that getOrCreateLog on a non-existent log creates a new log in
random logDirectory if the given directory id is DirectoryId.UNASSIGNED.
Review Comment:
Not random
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
