soarez commented on code in PR #14881: URL: https://github.com/apache/kafka/pull/14881#discussion_r1420691621
########## core/src/main/scala/kafka/server/ReplicaManager.scala: ########## @@ -2626,8 +2601,12 @@ class ReplicaManager(val config: KafkaConfig, localLeaders.forKeyValue { (tp, info) => getOrCreatePartition(tp, delta, info.topicId).foreach { case (partition, isNew) => try { + val partitionDirectoryId: Option[Uuid] = + Option(newImage.topics().getPartition(info.topicId(), partition.partitionId)).map(_.directory(localBrokerId)) Review Comment: Maybe we can default this to `MIGRATING` instead of an `Option`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org