hanyuzheng7 commented on code in PR #14907:
URL: https://github.com/apache/kafka/pull/14907#discussion_r1416481604
##########
streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredTimestampedKeyValueStore.java:
##########
@@ -205,12 +206,12 @@ private <R> QueryResult<R> runTimestampedRangeQuery(final
Query<R> query,
final QueryResult<R> result;
final TimestampedRangeQuery<K, V> typedQuery =
(TimestampedRangeQuery<K, V>) query;
RangeQuery<Bytes, byte[]> rawRangeQuery;
- final boolean isKeyAscending = typedQuery.isKeyAscending();
+ ResultOrder order = typedQuery.resultOrder();
rawRangeQuery = RangeQuery.withRange(
keyBytes(typedQuery.lowerBound().orElse(null)),
keyBytes(typedQuery.upperBound().orElse(null))
);
- if (!isKeyAscending) {
+ if (order.equals(ResultOrder.DESCENDING)) {
Review Comment:
https://github.com/apache/kafka/pull/14907#discussion_r1416481443
##########
streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredTimestampedKeyValueStore.java:
##########
@@ -268,12 +269,12 @@ private <R> QueryResult<R> runRangeQuery(final Query<R>
query,
final QueryResult<R> result;
final RangeQuery<K, V> typedQuery = (RangeQuery<K, V>) query;
RangeQuery<Bytes, byte[]> rawRangeQuery;
- final boolean isKeyAscending = typedQuery.isKeyAscending();
+ ResultOrder order = typedQuery.resultOrder();
rawRangeQuery = RangeQuery.withRange(
keyBytes(typedQuery.getLowerBound().orElse(null)),
keyBytes(typedQuery.getUpperBound().orElse(null))
);
- if (!isKeyAscending) {
+ if (order.equals(ResultOrder.DESCENDING)) {
Review Comment:
https://github.com/apache/kafka/pull/14907#discussion_r1416481443
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
