hanyuzheng7 commented on code in PR #14907:
URL: https://github.com/apache/kafka/pull/14907#discussion_r1416485410
##########
streams/src/main/java/org/apache/kafka/streams/query/RangeQuery.java:
##########
@@ -59,25 +58,25 @@ private RangeQuery(final Optional<K> lower, final
Optional<K> upper, final boole
* @param <V> The value type
*/
public static <K, V> RangeQuery<K, V> withRange(final K lower, final K
upper) {
- return new RangeQuery<>(Optional.ofNullable(lower),
Optional.ofNullable(upper), true);
+ return new RangeQuery<>(Optional.ofNullable(lower),
Optional.ofNullable(upper), ResultOrder.ANY);
}
/**
- * Determines if the serialized byte[] of the keys in ascending order.
+ * Determines if the serialized byte[] of the keys in ascending or any
order.
* Order is based on the serialized byte[] of the keys, not the 'logical'
key order.
- * @return true if ascending, false otherwise.
+ * @return return the order of returned records based on the serialized
byte[] of the keys(can be unordered, or in ascending or in descending order).
Review Comment:
But I didn't find where miss the space
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
