mjsax commented on code in PR #14957:
URL: https://github.com/apache/kafka/pull/14957#discussion_r1420051909


##########
streams/src/main/java/org/apache/kafka/streams/state/internals/LogicalSegmentIterator.java:
##########
@@ -34,7 +31,16 @@ public class LogicalSegmentIterator implements 
VersionedRecordIterator {
     private final Long fromTime;
     private final Long toTime;
     private final ResultOrder order;
-    private ListIterator<VersionedRecord<byte[]>> iterator;
+    // stores the raw value of the latestValueStore when latestValueStore is 
the current segment
+    private byte[] currentRawSegmentValue;
+    // stores the deserialized value of the current segment (when current 
segment is one of the old segments)
+    private RocksDBVersionedStoreSegmentValueFormatter.SegmentValue 
currentDeserializedSegmentValue;
+    // current segment minTimestamp (when current segment is not the 
latestValueStore)
+    private long minTimestamp;
+    // current segment nextTimestamp (when current segment is not the 
latestValueStore)
+    private long nextTimestamp;
+    private VersionedRecord next;
+    // current deserialization index

Review Comment:
   Wrong line?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to