aliehsaeedii commented on code in PR #14957:
URL: https://github.com/apache/kafka/pull/14957#discussion_r1420464501
##########
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBVersionedStoreSegmentValueFormatter.java:
##########
@@ -266,6 +276,11 @@ private static class PartiallyDeserializedSegmentValue
implements SegmentValue {
private int deserIndex = -1; // index up through which this segment
has been deserialized (inclusive)
private List<TimestampAndValueSize>
unpackedReversedTimestampAndValueSizes;
private List<Integer> cumulativeValueSizes; // ordered same as
timestamp and value sizes (reverse time-sorted)
+ private int valuesStartingIndex = -1; // the index of first value in
the segment
+ private int currentCumValueSize = 0; // this is for deserializing a
segment records in a lazy manner
+ private int currentDeserIndex = 0; // this is for deserializing a
segment records in a lazy manner
Review Comment:
> it seems we might want to change their name to indicate when (ascending vs
descending) they are used?
I use the same variable (my own defined one) for both directions. Since
deserialization is either backwards or forward and not both at the same time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
