pprovenzano commented on code in PR #14881:
URL: https://github.com/apache/kafka/pull/14881#discussion_r1421489097


##########
core/src/main/scala/kafka/log/LogManager.scala:
##########
@@ -123,7 +123,9 @@ class LogManager(logDirs: Seq[File],
   }
 
   private val dirLocks = lockLogDirs(liveLogDirs)
-  val directoryIds: Map[String, Uuid] = loadDirectoryIds(liveLogDirs)
+  private val directoryIds: mutable.Map[String, Uuid] = 
loadDirectoryIds(liveLogDirs)
+  def directoryIdsSet: Predef.Set[Uuid] = directoryIds.values.toSet
+
   @volatile private var recoveryPointCheckpoints = liveLogDirs.map(dir =>

Review Comment:
   You need to rebase your changes on top of latest apache/trunk
   This change needs to be applied to 
'core/src/main/scala/kafka/server/KafkaServer.scala' which was updated pass 
this set to `BrokerLifecycleManager` if the Zk broker has migration enabled.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to