OmniaGM commented on code in PR #14881: URL: https://github.com/apache/kafka/pull/14881#discussion_r1422522894
########## core/src/main/scala/kafka/cluster/Partition.scala: ########## @@ -867,6 +869,25 @@ class Partition(val topicPartition: TopicPartition, } } + private def createLogInAssignedDirectoryId(partitionState: LeaderAndIsrPartitionState, highWatermarkCheckpoints: OffsetCheckpoints, topicId: Option[Uuid], targetLogDirectoryId: Option[Uuid]): Unit = { + targetLogDirectoryId match { + case Some(directoryId) => + if (logManager.onlineLogDirId(directoryId)) { + if (logManager.getLog(topicPartition).isEmpty) { + createLogIfNotExists(partitionState.isNew, isFutureReplica = false, highWatermarkCheckpoints, topicId, targetLogDirectoryId) + } + } else if ((!logManager.onlineLogDirId(directoryId) && !logManager.hasOfflineLogDirs()) || directoryId == DirectoryId.UNASSIGNED) { + // select random directory if the directory Id is LOST or unknown and no offline directories or unassigned Review Comment: fixed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org