kirktrue commented on code in PR #14640:
URL: https://github.com/apache/kafka/pull/14640#discussion_r1423062667
##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImplTest.java:
##########
@@ -790,6 +812,197 @@ public void
testOnSubscriptionUpdatedTransitionsToJoiningOnlyIfNotInGroup() {
verify(membershipManager, never()).transitionToJoining();
}
+ @Test
+ public void testListenerCallbacksBasic() {
Review Comment:
@lianet said:
> When `onPartitionsRevoked` fails, we intentionally invoke the
`onPartitionsAssigned` anyways as I was mentioning above (experience the legacy
consumer provides), but we should end up failing the reconciliation as it
happens when `onPartitionsAssign` fails. Makes sense @kirktrue ?
This isn't what I'm seeing. In my new `MembershipManagerTest`
`testListenerCallbacksThrowsErrorOnPartitionsRevoked`, if an exception is
thrown from `onPartitionsRevoked()`, the reconciliation step for assignment is
skipped completely such that `onPartitionsAssigned()` is not called. Is that a
bug or no?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
