lianetm commented on code in PR #14640: URL: https://github.com/apache/kafka/pull/14640#discussion_r1424081933
########## clients/src/test/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImplTest.java: ########## @@ -790,6 +812,197 @@ public void testOnSubscriptionUpdatedTransitionsToJoiningOnlyIfNotInGroup() { verify(membershipManager, never()).transitionToJoining(); } + @Test + public void testListenerCallbacksBasic() { Review Comment: Actually I was missing the fact that the [thenCompose](https://github.com/apache/kafka/blob/bc4e2aaf3381297fbe2e947acac3ed692c7e7da0/clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java#L752) after the revocation is probably the one short-circuiting, so we do get the behaviour we want, of just aborting the reconciliation. So we can leave it like it is and enable the test. As a follow-up I would make the logic clearer, by having both callbacks leading to the failed reconciliation in the same way, but we can leave that out of this PR. I can handle that when I unify the callbacks with [KAFKA-15835](https://issues.apache.org/jira/browse/KAFKA-15835) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org