kirktrue commented on code in PR #14640:
URL: https://github.com/apache/kafka/pull/14640#discussion_r1424104151
##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImplTest.java:
##########
@@ -790,6 +812,197 @@ public void
testOnSubscriptionUpdatedTransitionsToJoiningOnlyIfNotInGroup() {
verify(membershipManager, never()).transitionToJoining();
}
+ @Test
+ public void testListenerCallbacksBasic() {
Review Comment:
Yes, the 'assigned' block that lives inside `thenCompose()` is never called
if the parent `Future` was completed exceptionally.
If I'm reading this correctly, we want to change the existing behavior for
the `AsyncKafkaConsumer` to _not_ call `onPartitionsAssigned()` if
`onPartitionsRevoked()` throws an exception. I'll update my tests accordingly.
That said, I imagine one or more of the integration tests will fail with
this change, so they will need to remain enabled only for `GENERIC`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
