aliehsaeedii commented on code in PR #14957: URL: https://github.com/apache/kafka/pull/14957#discussion_r1424245975
########## streams/src/main/java/org/apache/kafka/streams/state/internals/ReadonlyPartiallyDeserializedSegmentValue.java: ########## @@ -0,0 +1,210 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.streams.state.internals; + +import org.apache.kafka.streams.query.ResultOrder; + +import java.nio.ByteBuffer; +import java.util.HashMap; +import java.util.Map; + + +final class ReadonlyPartiallyDeserializedSegmentValue { + + private static final int TIMESTAMP_SIZE = 8; + private static final int VALUE_SIZE = 4; + private byte[] segmentValue; + private long nextTimestamp; + private long minTimestamp; + + private int deserIndex = -1; // index up through which this segment has been deserialized (inclusive) + + private Map<Integer, Integer> cumulativeValueSizes; + + private int valuesStartingIndex = -1; // the index of the first value in the segment (but the last one in the list) + private Map<Integer, TimestampAndValueSize> unpackedTimestampAndValueSizes = new HashMap<>(); + private int recordNumber = -1; // number of segment records + + + ReadonlyPartiallyDeserializedSegmentValue(final byte[] segmentValue) { + this.segmentValue = segmentValue; + this.nextTimestamp = + RocksDBVersionedStoreSegmentValueFormatter.getNextTimestamp(segmentValue); + this.minTimestamp = + RocksDBVersionedStoreSegmentValueFormatter.getMinTimestamp(segmentValue); + resetDeserHelpers(); + } + + + public long minTimestamp() { + return minTimestamp; + } + + public long nextTimestamp() { + return nextTimestamp; + } + + public byte[] serialize() { + return segmentValue; + } + + + public RocksDBVersionedStoreSegmentValueFormatter.SegmentValue.SegmentSearchResult find( + final long fromTime, final long toTime, final ResultOrder order, final int index) { + + // this segment does not have any record in query specified time range + if (toTime < minTimestamp || fromTime > nextTimestamp) { + return null; + } + + final boolean isAscending = order.equals(ResultOrder.ASCENDING); + + if (isAscending && valuesStartingIndex == -1) { + findValuesStartingIndex(); + deserIndex = recordNumber; + } + + long currTimestamp = -1; + long currNextTimestamp = -1; + int currIndex = initializeCurrentIndex(index, isAscending); + int cumValueSize = initializeCumValueSize(index, currIndex, isAscending); + int currValueSize; + + + while (hasStillRecord(currTimestamp, currNextTimestamp, order)) { + if (hasBeenDeserialized(isAscending, currIndex)) { + final TimestampAndValueSize curr; + curr = unpackedTimestampAndValueSizes.get(currIndex); + currTimestamp = curr.timestamp; + cumValueSize = cumulativeValueSizes.get(currIndex); + currValueSize = curr.valueSize; + + // update currValueSize + if (currValueSize == Integer.MIN_VALUE) { + final int timestampSegmentIndex = getTimestampIndex(order, currIndex); + currValueSize = ByteBuffer.wrap(segmentValue).getInt(timestampSegmentIndex + TIMESTAMP_SIZE); + unpackedTimestampAndValueSizes.put(currIndex, new TimestampAndValueSize(currTimestamp, cumValueSize)); Review Comment: > `cumValueSize` is not updated with `currValueSize`. Why? Yes, in fact in this if (if deserIndex is ahead of currIndex), we must have EVERYTHING ready. Therefore, `if (currValueSize == Integer.MIN_VALUE)` does not fit here. I removed it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
