pprovenzano commented on code in PR #14984: URL: https://github.com/apache/kafka/pull/14984#discussion_r1426151584
########## server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java: ########## @@ -194,8 +194,14 @@ public enum MetadataVersion { // Add JBOD support for KRaft. IBP_3_7_IV2(17, "3.7", "IV2", true), + // IBP_3_7_IV3 was ELR related supports (KIP-966) and has been moved forward + IBP_3_7_IV3(18, "3.7", "IV3", false), + + // Add new fetch request version for KIP-951 + IBP_3_7_IV4(19, "3.7", "IV4", false), + // Add ELR related supports (KIP-966). - IBP_3_7_IV3(18, "3.7", "IV3", true); + IBP_3_8_IV0(20, "3.8", "IV0", true); Review Comment: No, you asked to split this PR into two separate PRs, one for 3.7 without any reference to 3.8 and this one. I am saying that doing that has no value because 3.8 is labeled as unstable so having it in 3.7 isn't an issue. Customers cannot use 3.8 unless they explicitly allow unstable metadata versions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org