rondagostino commented on code in PR #14984:
URL: https://github.com/apache/kafka/pull/14984#discussion_r1426827635
##########
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##########
@@ -393,7 +400,7 @@ public short partitionRecordVersion() {
}
public short fetchRequestVersion() {
- if (this.isAtLeast(IBP_3_7_IV0)) {
+ if (this.isAtLeast(IBP_3_7_IV4)) {
Review Comment:
Noting that we do not have a test for this. In the interest of time, let's
add a test for this in a follow-on PR rather than here unless we find other
issues.
##########
tools/src/test/java/org/apache/kafka/tools/FeatureCommandTest.java:
##########
@@ -68,17 +68,17 @@ public void testDescribeWithKRaft() {
);
// Change expected message to reflect latest MetadataVersion
(SupportedMaxVersion increases when adding a new version)
assertEquals("Feature: metadata.version\tSupportedMinVersion:
3.0-IV1\t" +
- "SupportedMaxVersion: 3.7-IV3\tFinalizedVersionLevel:
3.3-IV1\t", outputWithoutEpoch(commandOutput));
+ "SupportedMaxVersion: 3.8-IV0\tFinalizedVersionLevel:
3.3-IV1\t", outputWithoutEpoch(commandOutput));
}
- @ClusterTest(clusterType = Type.KRAFT, metadataVersion =
MetadataVersion.IBP_3_7_IV0)
+ @ClusterTest(clusterType = Type.KRAFT, metadataVersion =
MetadataVersion.IBP_3_7_IV4)
Review Comment:
Seem that this change is unnecessary, but it doesn't hurt, either - so let's
leave it alone in the interest of time unless we find something else that
definitely needs fixing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
