cadonna commented on code in PR #15035:
URL: https://github.com/apache/kafka/pull/15035#discussion_r1432918143
##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java:
##########
@@ -525,16 +526,37 @@ public void testHeartbeatState() {
@Test
public void testPollTimerExpiration() {
- heartbeatRequestManager = createHeartbeatRequestManager();
+ coordinatorRequestManager = mock(CoordinatorRequestManager.class);
+ membershipManager = mock(MembershipManager.class);
+ heartbeatState = mock(HeartbeatRequestManager.HeartbeatState.class);
+ heartbeatRequestState = spy(new
HeartbeatRequestManager.HeartbeatRequestState(
Review Comment:
If it is too much work to change, let's change it later and merge it as it
is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
