satishd commented on code in PR #14034: URL: https://github.com/apache/kafka/pull/14034#discussion_r1442402411
########## checkstyle/import-control-core.xml: ########## @@ -37,6 +37,8 @@ <allow pkg="kafka.serializer" /> <allow pkg="org.apache.kafka.common" /> <allow pkg="org.mockito" class="AssignmentsManagerTest"/> + <allow pkg="org.apache.kafka.server.util"/> + <allow pkg="org.apache.kafka.storage.internals.log"/> Review Comment: Right, it is not needed. I guess it was needed when that class was kept inside the core module. ########## checkstyle/import-control-core.xml: ########## @@ -37,6 +37,8 @@ <allow pkg="kafka.serializer" /> <allow pkg="org.apache.kafka.common" /> <allow pkg="org.mockito" class="AssignmentsManagerTest"/> + <allow pkg="org.apache.kafka.server.util"/> + <allow pkg="org.apache.kafka.storage.internals.log"/> Review Comment: Right, it is not needed. I guess it was needed when that class was kept inside the core module. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
