nizhikov commented on code in PR #15158:
URL: https://github.com/apache/kafka/pull/15158#discussion_r1446240650


##########
core/src/main/scala/kafka/server/ClientQuotaManager.scala:
##########
@@ -51,15 +52,9 @@ case class ClientSensors(metricTags: Map[String, String], 
quotaSensor: Sensor, t
  *
  */
 case class ClientQuotaManagerConfig(numQuotaSamples: Int =

Review Comment:
   Do we really need instance fields in java version in this case?
   Maybe it will be more clear to keep only constants.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to