nizhikov commented on code in PR #15158: URL: https://github.com/apache/kafka/pull/15158#discussion_r1446246355
########## core/src/main/scala/kafka/server/ReplicationQuotaManager.scala: ########## @@ -39,18 +39,9 @@ import org.apache.kafka.common.utils.Time * @param quotaWindowSizeSeconds The time span of each sample * */ -case class ReplicationQuotaManagerConfig(quotaBytesPerSecondDefault: Long = QuotaBytesPerSecondDefault, Review Comment: > If this will make it easier It will make changes easier in my opinion. Moving things atomically with clear changes is always better choice. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
