rreddy-22 commented on code in PR #15152:
URL: https://github.com/apache/kafka/pull/15152#discussion_r1446770934
##########
core/src/test/scala/unit/kafka/coordinator/group/GroupCoordinatorAdapterTest.scala:
##########
@@ -327,23 +327,26 @@ class GroupCoordinatorAdapterTest {
@Test
def testListGroups(): Unit = {
- testListGroups(null, Set.empty)
- testListGroups(List(), Set.empty)
- testListGroups(List("Stable"), Set("Stable"))
+ testListGroups(null, null, Set.empty, Set.empty)
+ testListGroups(List(), List(), Set.empty, Set.empty)
+ testListGroups(List("Stable, Empty"), List(), Set("Stable, Empty"),
Set.empty)
Review Comment:
Yep thanks for bringing it up, we could add it, I considered it but it
didn't seem to add much value to the test so I decided against it at the time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
