C0urante commented on code in PR #15149:
URL: https://github.com/apache/kafka/pull/15149#discussion_r1447427203
##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/HerderRequestHandler.java:
##########
@@ -41,18 +41,11 @@ public class HerderRequestHandler {
private final RestClient restClient;
- private volatile long requestTimeoutMs;
+ private final RestRequestTimeout requestTimeout;
- public HerderRequestHandler(RestClient restClient, long requestTimeoutMs) {
+ public HerderRequestHandler(RestClient restClient, RestRequestTimeout
requestTimeout) {
this.restClient = restClient;
- this.requestTimeoutMs = requestTimeoutMs;
- }
-
- public void requestTimeoutMs(long requestTimeoutMs) {
- if (requestTimeoutMs < 1) {
- throw new IllegalArgumentException("REST request timeout must be
positive");
- }
Review Comment:
I removed it for two reasons:
1. This code path is only ever used in testing code
2. It's unclear that the validation would be safer than allowing negative
values. At least on my machine, negative values don't cause any issues with,
e.g., `ConvertingFutureCallback::get`.
##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/RestRequestTimeout.java:
##########
@@ -0,0 +1,26 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.kafka.connect.runtime.rest;
+
+public interface RestRequestTimeout {
Review Comment:
I could see some benefit to this, but it's also not a blocker.
It's also debatable, since this interface may change in the future and we
don't want to imply that it can only have exactly one abstract method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
