C0urante commented on code in PR #15149: URL: https://github.com/apache/kafka/pull/15149#discussion_r1447487472
########## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/HerderRequestHandler.java: ########## @@ -41,18 +41,11 @@ public class HerderRequestHandler { private final RestClient restClient; - private volatile long requestTimeoutMs; + private final RestRequestTimeout requestTimeout; Review Comment: Ah, gotcha. The intent was to make it thread-safe since it's likely that writes and reads to/of that value will take place on different threads. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org