philipnee commented on code in PR #15000: URL: https://github.com/apache/kafka/pull/15000#discussion_r1450704020
########## clients/src/main/java/org/apache/kafka/clients/consumer/internals/OffsetCommitCallbackInvoker.java: ########## @@ -0,0 +1,92 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.clients.consumer.internals; + +import org.apache.kafka.clients.consumer.OffsetAndMetadata; +import org.apache.kafka.clients.consumer.OffsetCommitCallback; +import org.apache.kafka.common.TopicPartition; +import org.apache.kafka.common.errors.FencedInstanceIdException; + +import java.util.Map; +import java.util.concurrent.BlockingQueue; +import java.util.concurrent.LinkedBlockingQueue; + +/** + * Utility class that helps the application thread to invoke user registered {@link OffsetCommitCallback} amd + * {@link org.apache.kafka.clients.consumer.ConsumerInterceptor}s. This is + * achieved by having the background thread register a {@link OffsetCommitCallbackTask} to the invoker upon the + * future completion, and execute the callbacks when user polls/commits/closes the consumer. + */ +public class OffsetCommitCallbackInvoker { + private final ConsumerInterceptors<?, ?> interceptors; + + OffsetCommitCallbackInvoker(ConsumerInterceptors<?, ?> interceptors) { + this.interceptors = interceptors; + } + + // Thread-safe queue to store user-defined callbacks and interceptors to be executed + private final BlockingQueue<OffsetCommitCallbackTask> callbackQueue = new LinkedBlockingQueue<>(); + + public void submitCommitInterceptors(final Map<TopicPartition, OffsetAndMetadata> offsets) { + if (!interceptors.isEmpty()) { + callbackQueue.add(new OffsetCommitCallbackTask( + (o, e) -> interceptors.onCommit(o), + offsets, + null + )); + } + } + + public void submitUserCallback(final OffsetCommitCallback callback, + final Map<TopicPartition, OffsetAndMetadata> offsets, + final Exception e) { Review Comment: would be more consistent with the styling - `exception` instead of `e`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
