philipnee commented on code in PR #15000:
URL: https://github.com/apache/kafka/pull/15000#discussion_r1453877053


##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumerTest.java:
##########
@@ -844,6 +849,54 @@ public void testWakeupCommitted() {
         assertNull(consumer.wakeupTrigger().getPendingTask());
     }
 
+    @Test

Review Comment:
   what's the interceptor behavior on close? if we have inflight commits before 
closing the consumer, should the interceptors be invoked? can we add tests 
around that?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to