apoorvmittal10 commented on code in PR #15148:
URL: https://github.com/apache/kafka/pull/15148#discussion_r1451062702
##########
clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryReporter.java:
##########
@@ -715,15 +716,22 @@ private Optional<Builder<?>>
createPushRequest(ClientTelemetrySubscription local
}
CompressionType compressionType =
ClientTelemetryUtils.preferredCompressionType(localSubscription.acceptedCompressionTypes());
- ByteBuffer buffer = ClientTelemetryUtils.compress(payload,
compressionType);
+ byte[] compressedPayload;
+ try {
+ compressedPayload = ClientTelemetryUtils.compress(payload,
compressionType);
+ } catch (IOException e) {
+ log.info("Failed to compress telemetry payload for
compression: {}, sending uncompressed data", compressionType);
Review Comment:
I think generally clients log such internal handling errors in INFO else end
application user sees that as an issue (if they see logs in WARN or ERROR),
that's my understanding. Maybe @philipnee @kirktrue can better address this.
I don't think there will be other scenarios where we fall back to
uncompressed data but client metrics is something where the compression is not
defined by the end user rather sent by server and automatically picked by
client.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
