philipnee commented on code in PR #15148:
URL: https://github.com/apache/kafka/pull/15148#discussion_r1453662602
##########
clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryReporter.java:
##########
@@ -715,15 +716,22 @@ private Optional<Builder<?>>
createPushRequest(ClientTelemetrySubscription local
}
CompressionType compressionType =
ClientTelemetryUtils.preferredCompressionType(localSubscription.acceptedCompressionTypes());
- ByteBuffer buffer = ClientTelemetryUtils.compress(payload,
compressionType);
+ byte[] compressedPayload;
+ try {
+ compressedPayload = ClientTelemetryUtils.compress(payload,
compressionType);
+ } catch (IOException e) {
+ log.info("Failed to compress telemetry payload for
compression: {}, sending uncompressed data", compressionType);
Review Comment:
I think WARN or INFO is sufficient as it is not necessary a fatal path. How
much should user care about getting uncompressed data? If they should try to
fix it maybe deserves a WARN level logging. If this is a potential issue to
the system then WARN is better.
Also, Should we log error to DEBUG log?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
