[
https://issues.apache.org/jira/browse/KAFKA-15863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17807315#comment-17807315
]
Apoorv Mittal commented on KAFKA-15863:
---------------------------------------
[~junrao] I looked at the code, suggestion of yours and KIP-714, it seems to me
that KIP wants 2 throttle checks i.e. 1 at request level with generic
throttling and 2 specific to time interval defined for push. I don't think we
need to have another quota defined specific to client telemetry as the intent
is to throttle the rogue client which we are anyways handling by default client
request quota. I have tested the behaviour by setting low value of client
request quota for `producer-1` client id, and can successfully see throttling
happening for push telemetry requests. I am marking the ticket as resolved,
please let me know if I am missing something.
cc: [~schofielaj].
{code:java}
[APM] Throttle check for : producer-1, time: 100.0890606
[APM] Checking quota for metric MetricName [name=request-time, group=Request,
description=Tracking request-time per user/client-id, tags={user=,
client-id=producer-1}] with value 10.00890606
[APM] Non-TokenBucket quota for metric MetricName [name=request-time,
group=Request, description=Tracking request-time per user/client-id,
tags={user=, client-id=producer-1}] with value 10.00890606
[APM] Quota.acceptable: 10.00890606 1.0 true
[2024-01-16 15:42:39,350] INFO Quota violated for sensor (Request-:producer-1).
Delay time: (1000) (kafka.server.ClientRequestQuotaManager)
[2024-01-16 15:42:39,350] INFO Channel throttled for sensor
(Request-:producer-1). Delay time: (1000)
(kafka.server.ClientRequestQuotaManager)
[APM] Throttling response for client producer-1 on broker is 1000ms, response
is PushTelemetryResponseData(throttleTimeMs=1000, errorCode=0){code}
> Handle push telemetry throttling with quota manager
> ---------------------------------------------------
>
> Key: KAFKA-15863
> URL: https://issues.apache.org/jira/browse/KAFKA-15863
> Project: Kafka
> Issue Type: Sub-task
> Reporter: Apoorv Mittal
> Assignee: Apoorv Mittal
> Priority: Major
>
> Details: https://github.com/apache/kafka/pull/14699#discussion_r1399714279
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
