lucasbru commented on code in PR #15000:
URL: https://github.com/apache/kafka/pull/15000#discussion_r1455670090
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##########
@@ -93,9 +94,11 @@ public CommitRequestManager(
final SubscriptionState subscriptions,
final ConsumerConfig config,
final CoordinatorRequestManager coordinatorRequestManager,
+ final OffsetCommitCallbackInvoker offsetCommitCallbackInvoker,
Review Comment:
This is very mixed across the clients codebase. Sometimes you put the final
sometimes you don't. In the streams module there is a strict rule to do. Not
sure, but as long as there is no guideline around this, and we are not
completely repulsed by it, I'd suggest to just stick with whatever the existing
code is doing for consistency to not mess up git blame too much.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
