dajac commented on code in PR #15183:
URL: https://github.com/apache/kafka/pull/15183#discussion_r1458501802
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetAndMetadata.java:
##########
@@ -92,30 +117,34 @@ public boolean equals(Object o) {
OffsetAndMetadata that = (OffsetAndMetadata) o;
- if (offset != that.offset) return false;
+ if (committedOffset != that.committedOffset) return false;
if (commitTimestampMs != that.commitTimestampMs) return false;
- if (!leaderEpoch.equals(that.leaderEpoch)) return false;
- if (!metadata.equals(that.metadata)) return false;
- return expireTimestampMs.equals(that.expireTimestampMs);
+ if (recordOffset != that.recordOffset) return false;
+ if (!Objects.equals(leaderEpoch, that.leaderEpoch)) return false;
Review Comment:
I don't think so. There is a feature to auto-generate equals and hashCode.
It has been around for a while now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
