dajac commented on code in PR #15183:
URL: https://github.com/apache/kafka/pull/15183#discussion_r1458504559
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java:
##########
@@ -918,7 +920,7 @@ public void replay(
groupId,
topic,
partition,
- OffsetAndMetadata.fromRecord(value)
+ OffsetAndMetadata.fromRecord(offset, value)
Review Comment:
I agree that it is a bit confusing. Let me rename `offset` to `recordOffset`
to make it clearer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
