OmniaGM commented on code in PR #15263:
URL: https://github.com/apache/kafka/pull/15263#discussion_r1469680659
##########
core/src/main/scala/kafka/cluster/Partition.scala:
##########
@@ -874,7 +874,13 @@ class Partition(val topicPartition: TopicPartition,
private def createLogInAssignedDirectoryId(partitionState:
LeaderAndIsrPartitionState, highWatermarkCheckpoints: OffsetCheckpoints,
topicId: Option[Uuid], targetLogDirectoryId: Option[Uuid]): Unit = {
targetLogDirectoryId match {
case Some(directoryId) =>
- createLogIfNotExists(directoryId == DirectoryId.UNASSIGNED,
isFutureReplica = false, highWatermarkCheckpoints, topicId,
targetLogDirectoryId)
+ if (logManager.onlineLogDirId(directoryId) ||
!logManager.hasOfflineLogDirs() || directoryId == DirectoryId.UNASSIGNED) {
+ createLogIfNotExists(partitionState.isNew, isFutureReplica = false,
highWatermarkCheckpoints, topicId, targetLogDirectoryId)
+ } else {
+ warn(s"Skipping creation of log because there are potentially
offline log " +
Review Comment:
> Is it because there are potentially offline log dir might already have the
logs? If so, does that mean we can't create any new topic while 1 log dir goes
offline?
My understanding of the original logic before JBOD is that we block creating
topic partition on broker if `partitionState.isNew` is false and the broker has
any offline log directories. This logic is in `LogManager.getOrCreateLog` which
will throw `KafkaStorageException`. Am not sure if we need to throw it here in
`Partition.createLogInAssignedDirectoryId` if it will be thrown anyway in
`LogManager.getOrCreateLog`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
