OmniaGM commented on code in PR #15263:
URL: https://github.com/apache/kafka/pull/15263#discussion_r1469696139
##########
core/src/main/scala/kafka/server/ReplicaManager.scala:
##########
@@ -183,7 +183,7 @@ object HostedPartition {
/**
* This broker hosts the partition, but it is in an offline log directory.
*/
- final object Offline extends HostedPartition
+ final case class Offline(topicId: Option[Uuid]) extends HostedPartition
Review Comment:
Specially that the signature for `Online` is `final case class
Online(partition: Partition)` so just to keep it some how consistent We can
have `Offline(topicIdPartition: Option[TopicIdPartition]`
_Note_: this is just a suggestion!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
