apoorvmittal10 opened a new pull request, #15281:
URL: https://github.com/apache/kafka/pull/15281

   Fix in the following https://github.com/apache/kafka/pull/15127 introduced a 
regression for `kafka-clients` pom where runtime dependencies were not included 
in the `kafka-clients` pom. The PR has a workaround to add the dependencies 
defined as `shadow/runtime` dependencies for `shadowJar` in clients `pom`.
   
   Though `project.shadow.component(mavenJava)` earlier used to add the runtime 
dependencies itself but as that creates an issue with `signing` of the jar 
which was removed in PR https://github.com/apache/kafka/pull/15127 hence this 
workaround is needed to add the `runtime` dependencies in pom.
   
   #### Difference in pom from 3.6.2 release:
   
   ![Screenshot 2024-01-29 at 2 32 25 
PM](https://github.com/apache/kafka/assets/2861565/b0f1d551-f997-4a00-93ed-80f738e3a23f)
   
   cc: @stanislavkozlovski @ijuma @xvrl 
   
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to