ijuma commented on code in PR #15281:
URL: https://github.com/apache/kafka/pull/15281#discussion_r1471416481
##########
build.gradle:
##########
@@ -303,6 +303,20 @@ subprojects {
} else {
apply plugin: 'com.github.johnrengelman.shadow'
artifact shadowJar
+ // work around issue with 'shadow' to resolve runtime dependencies
correctly. This requires
+ // any project relying on 'shadow' dependencies.
+ afterEvaluate {
+ pom.withXml { xml ->
+ def dependenciesNode = xml.asNode().appendNode('dependencies')
+ project.configurations.shadow.allDependencies.each {
+ def dependencyNode =
dependenciesNode.appendNode('dependency')
+ dependencyNode.appendNode('groupId', it.group)
+ dependencyNode.appendNode('artifactId', it.name)
+ dependencyNode.appendNode('version', it.version)
+ dependencyNode.appendNode('scope', 'runtime')
Review Comment:
A fix that involves updating the pom.xml directly doesn't seem right. For
example, does that mean that
https://docs.gradle.org/current/userguide/publishing_gradle_module_metadata.html
is not updated?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
