nicktelford commented on code in PR #15264:
URL: https://github.com/apache/kafka/pull/15264#discussion_r1476237948
##########
streams/src/main/java/org/apache/kafka/streams/state/internals/AbstractSegments.java:
##########
@@ -152,6 +153,13 @@ public List<S> allSegments(final boolean forward) {
return result;
}
+ @Override
+ public long approximateNumUncommittedBytes() {
Review Comment:
I've added some tests, but since it's not possible to mock the segments
themselves, and by default they just return `0` uncommitted bytes, it's not
really possible to test that it's correctly summing this until it's possible to
enable transaction buffers in the future. I've added a note that the test will
consequently need updating later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
