nicktelford commented on code in PR #15264:
URL: https://github.com/apache/kafka/pull/15264#discussion_r1485911481
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java:
##########
@@ -1889,7 +1925,8 @@ private int
commitTasksAndMaybeUpdateCommittableOffsets(final Collection<Task> t
if (rebalanceInProgress) {
return -1;
} else {
- return
taskExecutor.commitTasksAndMaybeUpdateCommittableOffsets(tasksToCommit,
consumedOffsetsAndMetadata);
+ final int committedOffsets =
taskExecutor.commitTasksAndMaybeUpdateCommittableOffsets(tasksToCommit,
consumedOffsetsAndMetadata);
Review Comment:
An earlier version of this PR reset `lastUncommittedBytes` to `0` between
this line and the `return`. I removed that but neglected to simplify it back.
Thanks for pointing this out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
