dajac commented on code in PR #15311:
URL: https://github.com/apache/kafka/pull/15311#discussion_r1477940236
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/RequestState.java:
##########
@@ -106,6 +106,13 @@ public void onSendAttempt(final long currentTimeMs) {
this.lastSentMs = currentTimeMs;
}
+ /**
+ * Update the lastReceivedTime in milliseconds, indicating that a response
has been received.
+ */
+ public void updateLastReceivedTime(final long lastReceivedMs) {
+ this.lastReceivedMs = lastReceivedMs;
Review Comment:
I find doing this a little strange because we ends up in a state where the
last received time is updated but the backoff and the number of attempts are
not. Therefore, we could still have an non-desired backoff applied to the next
request. For instance, imagine having a request timeout followed by a
coordinator not available error. Is this case, the backoff is not reset. Is my
understanding correct?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
