gharris1727 commented on PR #15349: URL: https://github.com/apache/kafka/pull/15349#issuecomment-1936929467
@dajac Maybe I misunderstand, but I don't see how the change you linked is relevant. If you run the tests once (as in locally running `./gradlew unitTest`) then the retries and merging of flaky tests in XML doesn't have an effect. And if you're using retries and merging the XML (as in Jenkins), you aren't using the unitTest target. But to your point: I agree that those tests are not integration tests according to the normal definitions, and this PR is effectively mis-using the terminology to instead mean: * deterministic and fast: unit * flaky or slow: integration This division makes the unitTest target useful for reliable CI gating, something that we need urgently. I suggested using a different tag for this, but others pushed back on this because the integration tag already does what we need, and another tag would have the same effect but a larger diff. But perhaps a `integration` tag, a `flaky` tag, and a `slow` tag could all be useful as in-line documentation as to why the test is demoted from unitTest. I agree that these tests would be valuable to add to the unitTest argument, but I think that they should only be present once they are de-flaked. It is surprising to me that such foundational unit tests are flaky, and maybe that means that we should prioritize fixing them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
